Whenever the arrow keys were pressed, there was an error and the extension crashed. I fixed it, sending the correct key to the pico board so that the functionality works fine!

Does this close any currently open issues?

It fixes issues: #115, #105 and #77

Any relevant logs, error output, etc?

(If it’s long, please paste to https://gist.github.com and insert the link here)

Where has this been tested?

Operating system: Windows and Mac

Hi Chris, thanks a lot for your adaption of mymakr to Pi Pico.

I found out, that I can use it also for other boards, f.e. ESP32 and ESP6288 as long as they don't use a CH340 chip for Serial-USB. These chips (at least sometimes) have no manufacturer string and are not accepted for auto connect.

What does this implement/fix? Explain your changes.

I changed one line of code: If there is no manufacturer string then I take the vendorId to look it up in the list autoconnect_comport_manufacturers.

Does this close any currently open issues?

No

Where has this been tested?

I tested it with witty and ttgo boards.

What does this implement/fix? Explain your changes.

When activating Pico-Go extension, the extension throw an error. To prevent this I have change the check from :

    if (this.statusbar_buttons == undefined || this.statusbar_buttons == '') {
          this.statusbar_buttons = ['status', 'connect', 'upload', 'download',
            'run', 'softreset'
          ];
    }

to :

    if (!Array.isArray(typeof this.statusbar_buttons)) {
      this.statusbar_buttons = ['status', 'connect', 'upload', 'download',
        'run', 'softreset'
      ];
    }

Does this close any currently open issues?

Close #113

Any relevant logs, error output, etc?

Any other comments?

Where has this been tested?

Tested in VSC debugger.

Operating system: macOS Monterey 12.1

VSCode version: 1.63.2

Pico-Go version: 1.4.3

What does this implement/fix? Explain your changes.

In Terminal Window connected to pico, when I type help(), I was having BlockingIOError.

Checked the code and found no reason to use O_NONBLOCK for stdout. Having no problem without O_NONBLOCK so far.

Does this close any currently open issues?

No.

Any relevant logs, error output, etc?

(If it’s long, please paste to https://gist.github.com and insert the link here) This is the error I was having, in the middle of help() output screen.

Traceback (most recent call last): File "/Users/yjchun/conda/lib/python3.9/threading.py", line 954, in _bootstrap_inner self.run() File "/Users/yjchun/conda/lib/python3.9/threading.py", line 892, in run self._target(*self._args, **self._kwargs) File "/Users/yjchun/.vscode/extensions/chriswood.pico-go-1.4.3/terminalExec.py", line 127, in runServer serviceConnection(key, mask) File "/Users/yjchun/.vscode/extensions/chriswood.pico-go-1.4.3/terminalExec.py", line 47, in serviceConnection boardInput(recv_data) File "/Users/yjchun/.vscode/extensions/chriswood.pico-go-1.4.3/terminalExec.py", line 85, in boardInput sys.stdout.write(data.decode("utf-8")) BlockingIOError: [Errno 35] write could not complete without blocking

Any other comments?

Where has this been tested?

Pico-Go:      1.4.3
VS Code:      1.59.1
Electron:     13.1.7
Modules:      89
Node:         14.16.0
Platform:     darwin
Architecture: x64
Board:        Raspberry Pi Pico with RP2040
Firmware:     v1.16-262-g89145c6aa on 2021-09-01 (GNU 9.3.1 MinSizeRel)

What does this implement/fix? Explain your changes.

• Uses ES6 Javascript throughout;
• Removed callback spaghetti;
• Removed redundant code;
• Refactored serial comms code code;
• Normalised naming conventions to PascalCase for classes and camelCase for methods and variables;
• Uses let and const instead of var;
• Semi-colons now used throughout;
• Generally beautified code.

Does this close any currently open issues?

Fixes #35